-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Closed
Labels
enhancementThis issue is a user-facing general improvement that doesn't fix a bug or add a new featureThis issue is a user-facing general improvement that doesn't fix a bug or add a new featurenew featureThis change adds new functionality, like a new method or classThis change adds new functionality, like a new method or class
Description
Prerequisites
- I have written a descriptive issue title
- I have searched existing issues to ensure the feature has not already been requested
🚀 Feature Proposal
Right now any invocation of createConnection(...) will cause the openUri() call in this conditional to get triggered:
Lines 350 to 352 in 8d9df24
| if (arguments.length > 0) { | |
| conn.openUri(uri, options, callback); | |
| } |
We suggest to add an option to createConnection of options.openUri: true and if false then this is not called.
- if (arguments.length > 0) {
+ if (arguments.length > 0 && options.openUri) {
conn.openUri(uri, options, callback);
}Metadata
Metadata
Assignees
Labels
enhancementThis issue is a user-facing general improvement that doesn't fix a bug or add a new featureThis issue is a user-facing general improvement that doesn't fix a bug or add a new featurenew featureThis change adds new functionality, like a new method or classThis change adds new functionality, like a new method or class